Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSI 598] - Removing binding.pem from php container and using mtlsproxyhost for search-gateway {Wordpress Site} #635

Conversation

@amarnath-ayyadurai-23 amarnath-ayyadurai-23 requested a review from a team as a code owner November 18, 2024 06:54
@pwtyler
Copy link
Member

pwtyler commented Nov 18, 2024

As discussed in Slack, breaking changes that rely on running the latest version of the plugin are difficult.

  • Env variables should be adjusted where they are set rather than adding new ones to the plugin
  • use a self-generated cert at /certs/binding.pem that can't be used for mTLS.

We might consider making backwards compatible changes (i.e. wrap the curl_setopt in a if ! file_exists, or a function that checks multiple env variables) allowing us to clean up compatibility choices after a certain time frame or adoption threshold.

@pwtyler pwtyler closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants